Create standalone OpenTelemetry stack and make some minor fixes#38
Open
ThijsFeryn wants to merge 14 commits into
Open
Create standalone OpenTelemetry stack and make some minor fixes#38ThijsFeryn wants to merge 14 commits into
ThijsFeryn wants to merge 14 commits into
Conversation
gquintard
requested changes
May 12, 2026
Collaborator
gquintard
left a comment
gquintard
left a comment
There was a problem hiding this comment.
on principle, I fully agree with this PR, but there are way too many things that didn't need to change
| "datasource": { | ||
| "type": "loki", | ||
| "uid": "lokiUID" | ||
| "uid": "loki" |
Collaborator
There was a problem hiding this comment.
I don't think this need to change, same for all the other changes in this directory
| @@ -0,0 +1,65 @@ | |||
| apiVersion: 1 | |||
Collaborator
There was a problem hiding this comment.
this is a sideway change, please create a different PR if you really want to merge those files
Comment on lines
-1
to
-11
| [security] | ||
| admin_user = admin | ||
| admin_password = password | ||
|
|
||
| #[auth] | ||
| #disable_login_form = true | ||
| # | ||
| #[auth.anonymous] | ||
| #enabled = true | ||
| #org_role = Admin | ||
|
|
Collaborator
There was a problem hiding this comment.
pretty sure you need this for tempo to push metrics to prometheus, but this was a while ago, maybe it has changed
| @@ -0,0 +1,48 @@ | |||
| stream_over_http_enabled: true | |||
Collaborator
There was a problem hiding this comment.
this is a pretty gratuitous rename of the file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the use of the
--profileflag fordocker compose.A regular
docker compose upwill only start the telemetry containers. Varnish, Varnish OTEL, the origin servers, and the load generator will not be started.The
README.mdfile explains how to rundocker compose --profile varnish up -dto start the full stack anddocker compose up -dfor the standalone OTEL stack.I also introduced an OTEL Collector container that forwards its telemetry data to Prometheus, Loki & Tempo. While it's an extra container, it simplifies shipping logs, metrics & traces from the various services.
I also ensured Grafana can be accessed without credentials on http://localhost:3000.
This PR replaces #37